Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-327: Do not attempt to extract files from unknown archive types. #333

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Aug 19, 2024

Fixes a case where dependencies on non-archive types result in an error.

TODO

  • Test case to reproduce this and prove it is fixed.
  • Refactor code to use a set.
  • Check if I have missed any other archive types covered by the JAR archive format.

@ascopes ascopes added the bug Something isn't working label Aug 19, 2024
@ascopes ascopes self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (9ab25d2) to head (67ba718).
Report is 2 commits behind head on main.

Files Patch % Lines
...otobufmavenplugin/sources/ProtoSourceResolver.java 82.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   87.71%   87.50%   -0.20%     
==========================================
  Files          36       36              
  Lines        1057     1064       +7     
  Branches       75       76       +1     
==========================================
+ Hits          927      931       +4     
- Misses         98      100       +2     
- Partials       32       33       +1     
Files Coverage Δ
...otobufmavenplugin/sources/ProtoSourceResolver.java 84.22% <82.36%> (-6.11%) ⬇️

@ascopes ascopes marked this pull request as ready for review August 19, 2024 15:49
@ascopes
Copy link
Owner Author

ascopes commented Aug 19, 2024

Will cover the tests separately, releasing as a bugfix for now.

@ascopes
Copy link
Owner Author

ascopes commented Aug 19, 2024

Fixes GH-327

@ascopes ascopes linked an issue Aug 19, 2024 that may be closed by this pull request
@ascopes ascopes merged commit ef7f383 into main Aug 19, 2024
12 of 14 checks passed
@ascopes ascopes deleted the bugfix/GH-327 branch August 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.UnsupportedOperationException in ZipFileSystemProvider
1 participant