Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Shlex class now it is no longer needed #400

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Sep 23, 2024

GH-399 removed the need for the Shlex class anymore, and most of the complexity is able to be inlined/removed entirely now.

This PR totally removes the implementation.

@ascopes ascopes added the general improvements Fixing/updating internal components and code label Sep 23, 2024
@ascopes ascopes added this to the v2.6.x milestone Sep 23, 2024
@ascopes ascopes self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (c66825b) to head (f92fb56).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...protobufmavenplugin/plugins/JvmPluginResolver.java 77.09% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   89.05%   87.76%   -1.28%     
==========================================
  Files          34       33       -1     
  Lines        1159     1119      -40     
  Branches       81       74       -7     
==========================================
- Hits         1032      982      -50     
- Misses         93      103      +10     
  Partials       34       34              
Files with missing lines Coverage Δ
...rotobufmavenplugin/protoc/CommandLineExecutor.java 77.28% <100.00%> (+0.68%) ⬆️
...protobufmavenplugin/plugins/JvmPluginResolver.java 84.51% <77.09%> (-6.17%) ⬇️

@ascopes ascopes marked this pull request as ready for review September 23, 2024 07:21
@ascopes ascopes merged commit b97acb2 into main Sep 23, 2024
13 of 15 checks passed
@ascopes ascopes deleted the task/remove-shlex branch September 23, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general improvements Fixing/updating internal components and code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant