Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noisy logging in SystemPathBinaryResolver.java #406

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Sep 28, 2024

No description provided.

@ascopes ascopes added the general improvements Fixing/updating internal components and code label Sep 28, 2024
@ascopes ascopes added this to the v2.6.x milestone Sep 28, 2024
@ascopes ascopes self-assigned this Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (2eb9440) to head (8577ce2).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...bufmavenplugin/utils/SystemPathBinaryResolver.java 66.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   87.76%   87.65%   -0.11%     
==========================================
  Files          33       33              
  Lines        1119     1117       -2     
  Branches       74       74              
==========================================
- Hits          982      979       -3     
- Misses        103      104       +1     
  Partials       34       34              
Files with missing lines Coverage Δ
...bufmavenplugin/utils/SystemPathBinaryResolver.java 50.00% <66.67%> (-5.00%) ⬇️

@ascopes ascopes merged commit 5d07f98 into main Sep 28, 2024
13 of 15 checks passed
@ascopes ascopes deleted the task/noisy-logging branch September 28, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general improvements Fixing/updating internal components and code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant