Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic in ArgFileBuilder #413

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Oct 2, 2024

No description provided.

@ascopes ascopes added the general improvements Fixing/updating internal components and code label Oct 2, 2024
@ascopes ascopes added this to the v3.0.x milestone Oct 2, 2024
@ascopes ascopes self-assigned this Oct 2, 2024
@ascopes ascopes modified the milestones: v3.0.x, v2.6.x Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (93cc667) to head (c1cf94f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          33       33           
  Lines        1117     1117           
  Branches       74       75    +1     
=======================================
  Hits          979      979           
  Misses        104      104           
  Partials       34       34           
Files with missing lines Coverage Δ
...protobufmavenplugin/plugins/JvmPluginResolver.java 84.40% <100.00%> (-0.10%) ⬇️
...protobufmavenplugin/utils/ArgumentFileBuilder.java 100.00% <100.00%> (ø)

@ascopes ascopes merged commit d91962b into main Oct 2, 2024
20 checks passed
@ascopes ascopes deleted the task/simplify-arg-file-builder branch October 2, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general improvements Fixing/updating internal components and code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant