Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-421: Ensure temporary spaces and plugin scratches cannot collide #422

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Oct 12, 2024

  • Temporary spaces are now scoped to the current goal and execution ID.
  • JVM plugin hashes now include an increasing index to prevent duplicate plugins in the same execution overwriting the same files in the scratch space.

Fixes GH-421.

@ascopes ascopes added bug Something isn't working general improvements Fixing/updating internal components and code labels Oct 12, 2024
@ascopes ascopes added this to the v2.6.x milestone Oct 12, 2024
@ascopes ascopes self-assigned this Oct 12, 2024
- Temporary spaces are now scoped to the current goal
  and execution ID.
- JVM plugin hashes now include an increasing index to
  prevent duplicate plugins in the same execution
  overwriting the same files in the scratch space.
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (84ad167) to head (a06ac68).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   87.65%   87.71%   +0.06%     
==========================================
  Files          33       33              
  Lines        1117     1122       +5     
  Branches       75       75              
==========================================
+ Hits          979      984       +5     
  Misses        104      104              
  Partials       34       34              
Files with missing lines Coverage Δ
...protobufmavenplugin/generation/TemporarySpace.java 86.67% <100.00%> (+4.85%) ⬆️
...protobufmavenplugin/plugins/JvmPluginResolver.java 84.51% <100.00%> (+0.11%) ⬆️

@ascopes ascopes marked this pull request as ready for review October 13, 2024 08:30
@ascopes ascopes merged commit 071774e into main Oct 13, 2024
13 checks passed
@ascopes ascopes deleted the bugfix/GH-421 branch October 13, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working general improvements Fixing/updating internal components and code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle reusing plugins across executions in a better way.
1 participant