Improve executor shutdown failsafe and tests #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascopes
added
the
general improvements
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 87.76% 87.77% +0.02%
==========================================
Files 33 33
Lines 1127 1128 +1
Branches 76 76
==========================================
+ Hits 989 990 +1
Misses 104 104
Partials 34 34
|
ascopes
force-pushed
the
task/improve-executor-shutdown
branch
2 times, most recently
from
e7cc677
to
e5df858
Compare
- Use fixedThreadPool - Use a thread group to enforce meaningful thread naming - Force all pooled threads to be daemon threads if not using virtual threads.
ascopes
force-pushed
the
task/improve-executor-shutdown
branch
from
e5df858
to
a0beba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.