Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hook versions, remove scipy devdep #1842

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Update pre-commit hook versions, remove scipy devdep #1842

merged 5 commits into from
Oct 2, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Oct 2, 2024 •
edited
Loading

Description

Some minor CI maintenance:

  • update pre-commit hook versions (and fix newly failing style checks)
  • remove scipy devdep, we don't depend on scipy and previously added it when numpy 2 was in development, let's see if we still need it (hopefully not as their dev wheels are broken causing our current devdeps to fail)

Checklist:

  • pre-commit checks ran successfully

  • tests ran successfully

  • for a public change, added a towncrier news fragment

    changes/<PR#>.<changetype>.rst

    • changes/<PR#>.feature.rst: new feature
    • changes/<PR#>.bugfix.rst: bug fix
    • changes/<PR#>.doc.rst: documentation change
    • changes/<PR#>.removal.rst: deprecation or removal of public API
    • changes/<PR#>.general.rst: infrastructure or miscellaneous change

  • for a public change, updated documentation

  • for any new features, unit tests were added

@braingram braingram changed the title Mnt ci Update pre-commit hook versions, remove scipy devdep Oct 2, 2024
@braingram braingram marked this pull request as ready for review October 2, 2024 13:36
@braingram braingram requested a review from a team as a code owner October 2, 2024 13:36
@braingram braingram merged commit 25b8aaa into asdf-format:main Oct 2, 2024
48 checks passed
@braingram braingram deleted the mnt_ci branch October 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
Downstream CI no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @zacharyburnett