feat: Make asdf latest more ergonomic by outputting plugin name
#1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first run, the /tmp folder doesn't exist. Using mkdir -p would be harmless and squashes this warning.
I frequently find myself wanting to query the latest version of a thing, and subsequently pinning it in my current repository. At the moment, i have to manually munge the output, which is just the version string, to be prefixed by the plugin name. Previously: ``` $ asdf latest ruby 2 2.7.8 $ asdf latest ruby 2 >> .tool-versions $ # ... pain / manual editing / argh $ asdf install ruby 2.7.8 installed ``` After this change: ``` $ asdf latest ruby 2 ruby 2.7.8 $ asdf latest ruby 2 >> .tool-versions $ # no pain! $ asdf install ruby 2.7.8 installed ```
toothbrush
changed the title
asdf latest a bit more ergonomicasdf latest more ergonomic by outputting plugin name
Seems this breaks a ton of things in the test suite, unfortunately. This reverts commit c775a70.
|
Hm, i've just realised that the I have also learned that I think i'll close this PR and think about a different approach. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have a friction point: I frequently find myself wanting to query the latest version of a plugin, and subsequently pinning it in my current directory.
At the moment, i have to manually munge the output of
asdf latest, because it gives just the version string, but i need to add the plugin's name as a prefix.Maybe a shell session will illustrate my friction point:
Previously:
After this change:
Other Information
By default, the behaviour of
asdf latestis unchanged. However, i've introduced a config optionversion_with_plugin_name& documentation to opt into my proposed new behaviour. This should make the transition seamless and non-breaking for those that want it. I'm happy to modify the name of the config option to something clearer.This is an improved version of #1704.