Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark current resolved versions in asdf list output #762

Merged
merged 6 commits into from
Jun 21, 2022
Merged

feat: mark current resolved versions in asdf list output #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31884ab
updated to pass wflow checks eg thru lint etc
Jul 12, 2020
61dcae9
Merge branch 'master' into tmp
jthegedus Jun 20, 2022
7f541eb
ci: test different ppa for Fish
jthegedus Jun 21, 2022
cef50ac
ci: revert changes to fish installation
jthegedus Jun 21, 2022
64ea460
chore: use local for func scoped var
jthegedus Jun 21, 2022
90e5f62
test: assert list cmd marks selected version
jthegedus Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/commands/command-list.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ display_installed_versions() {
local plugin_name=$1
local query=$2
local versions
local current_version
local flag

versions=$(list_installed_versions "$plugin_name")

if [[ $query ]]; then
Expand All @@ -39,8 +42,14 @@ display_installed_versions() {
fi

if [ -n "${versions}" ]; then
current_version=$(cut -d '|' -f 1 <<<"$(find_versions "$plugin_name" "$(pwd)")")

for version in $versions; do
printf " %s\\n" "$version"
flag=" "
if [[ "$version" == "$current_version" ]]; then
flag=" *"
fi
printf "%s%s\\n" "$flag" "$version"
done
else
display_error ' No versions installed'
Expand Down
15 changes: 15 additions & 0 deletions test/list_command.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ setup() {
setup_asdf_dir
install_dummy_plugin
install_dummy_broken_plugin

PROJECT_DIR=$HOME/project
mkdir $PROJECT_DIR
}

teardown() {
Expand All @@ -21,6 +24,18 @@ teardown() {
[ "$status" -eq 0 ]
}

@test "list_command should list plugins with installed versions and any selected versions marked with asterisk" {
cd $PROJECT_DIR
echo 'dummy 1.1.0' >>$PROJECT_DIR/.tool-versions
run asdf install dummy 1.0.0
run asdf install dummy 1.1.0

run asdf list
[[ "$output" == *"$(echo -e "dummy\n 1.0.0\n *1.1.0")"* ]]
[[ "$output" == *"$(echo -e "dummy-broken\n No versions installed")"* ]]
[ "$status" -eq 0 ]
}

@test "list_command should continue listing even when no version is installed for any of the plugins" {
run install_mock_plugin "dummy"
run install_mock_plugin "mummy"
Expand Down