Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for new users coming from Homebrew revision 2 #898

Closed
wants to merge 2 commits into from

Conversation

seivan
Copy link

@seivan seivan commented Mar 19, 2021

Reflect changes introduced in Homebrew/homebrew-core#73173

Summary

Existing solutions like source "$(brew --prefix asdf)/asdf.sh" will still work, so there is no need to migrate.
There will be one level of indirection as that will source the real path /usr/local/opt/asdf/libexec/asdf.sh

The documentation reflects the changes for new users and new paths for various shell scripts.

  • How to add shims to $PATH
  • How to source "$(brew --prefix asdf)/libexec/lib/asdf.sh" to get $ asdf shell <package> <version>

@seivan seivan requested a review from a team as a code owner March 19, 2021 06:44
@seivan seivan changed the title Update core-manage-asdf.md Update documentation for Homebrew changes. Mar 19, 2021
@seivan seivan changed the title Update documentation for Homebrew changes. Update documentation for new users coming from Homebrew revision 2 Mar 19, 2021
@jthegedus
Copy link
Contributor

How to add shims to $PATH

Is this a requirement for existing users too?

@seivan
Copy link
Author

seivan commented Mar 23, 2021

How to add shims to $PATH

Is this a requirement for existing users too?

Nope.

@jthegedus
Copy link
Contributor

I appreciate your work on this @seivan , sorry for the delay with reviewing all this.

@seivan
Copy link
Author

seivan commented Mar 23, 2021

@jthegedus Btw, the Fish stuff needs an extra set of eyes, and I haven't tested Bash.
However Zsh is pretty solid.

@seivan
Copy link
Author

seivan commented Mar 23, 2021

I appreciate your work on this @seivan , sorry for the delay with reviewing all this.

Yeah no worries, asdf has potential, but it's very messy if I can be blunt. I got a list of things I'd want to discuss if you'd be open to it.

@jthegedus
Copy link
Contributor

I got a list of things I'd want to discuss if you'd be open to it.

For longer form discussions and feedback please use GitHub Discussions and tag me. Keep in mind that the core asdf team probably also want the changes you're thinking of, but just haven't had the time or capcity to get to it.

@jthegedus
Copy link
Contributor

the Fish stuff needs an extra set of eyes, and I haven't tested Bash

If you can corral some Homebrew users to test that would be good.

@seivan
Copy link
Author

seivan commented Mar 23, 2021

I'm setting up images to test, so far for setting up $PATH changes in https://rootnroll.com/d/fish-shell/ seems fine.

  • Set up path
  • Test completion
  • Test libexec/lib/asdf.fish

@seivan seivan closed this Apr 2, 2021
@seivan seivan deleted the patch-3 branch April 2, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants