v3 Directory client #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the reader, writer and manifest interfaces. Bump dependencies.
Update interfaces with optional field to make the java api similar to the proto definitions.
Add more integration test for the directory api. Removed junit-platform-runner as it was interfering with the Junit5 tests.
BogdanIrimie
force-pushed
the
directory-client
branch
2 times, most recently
from
ddea6fb to
2a66e9d
Compare
Use assertj to improve assertions in tests.
BogdanIrimie
force-pushed
the
directory-client
branch
from
2a66e9d to
2602cc9
Compare
BogdanIrimie
force-pushed
the
directory-client
branch
from
d6dadcc to
5a0053b
Compare
Set manifest and import data before each integration tests. Extend the Directory writer and exporter interface.
BogdanIrimie
force-pushed
the
directory-client
branch
from
3106b37 to
d0fc13b
Compare
BogdanIrimie
requested review from
ronenh,
florindragos,
gertd,
carabasdaniel and
oanatmaria
gimmyxd
reviewed
Nov 27, 2023
examples/directory-example/src/main/java/org/example/DirectoryExample.java
Outdated
Show resolved
Hide resolved
gimmyxd
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.