Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated citadel data in v3 branch #152

Merged
merged 1 commit into from
Oct 23, 2023
Merged

updated citadel data in v3 branch #152

merged 1 commit into from
Oct 23, 2023

Conversation

ogazitt
Copy link
Contributor

@ogazitt ogazitt commented Oct 22, 2023

replicated the Citadel data changes in the v3 branch, where maestro is getting this data.

@gertd
Copy link
Member

gertd commented Oct 22, 2023

We will need to add v3 versions as well

gertd
gertd approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@gertd gertd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add v3 version, using the v3 object and relation formats as well

@ogazitt
Copy link
Contributor Author

ogazitt commented Oct 22, 2023

We will need to add v3 version, using the v3 object and relation formats as well

Is there a file that I should update in this branch? Or is this future work that needs to be done? Or in a different branch?

@ogazitt ogazitt merged commit 5c18154 into v3 Oct 23, 2023
5 checks passed
@ogazitt ogazitt deleted the fix/citadel-data-v3 branch October 23, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gertd gertd gertd approved these changes

@carabasdaniel carabasdaniel Awaiting requested review from carabasdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogazitt @gertd