Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gdrive ds-load json #154

Closed
wants to merge 48 commits into from
Closed

fix gdrive ds-load json #154

wants to merge 48 commits into from

Conversation

florindragos
Copy link
Contributor

No description provided.

ronenh and others added 17 commits October 6, 2023 17:16
Add console experience for topaz
* fix migrate test
* add service cleanup
This reverts commit 5b5dfd9.
* migrate all builtins to be v3 based, adds handling for v2 and v3 request payloads, v2 request return v2 results, help * is always v3 based
* migrate and reorganize tests, remove gomega/ginko dependency
* add service cleanup, the cleanup function returned by wire does not cleanup, leaving the database open
@gertd
Copy link
Member

gertd commented Oct 27, 2023

Please note:

  1. The data format is a V2 format, which cannot be used as we need subject_relation to be populated, so this must be updated to a V3 format
  2. There has been no validation of the manifest or data so far, so assume this is NOT final

Copy link
Member

@gertd gertd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object and relation formats used are v2 formats, gDrive requires subject_relation to be able to be expressed and set in the relations; hence the data format should be updated to V3 object and relation shapes.

Base automatically changed from v3 to main November 4, 2023 02:50
@gertd
Copy link
Member

gertd commented Nov 16, 2023

@florindragos is this PR still needed?

@gertd gertd deleted the fix_gdrive branch November 28, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants