-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gdrive ds-load json #154
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add OpenAPI support * upd deps
* Initial commit * gdrive it is * Fixing image paths, and updating emails
Replace 0.0.0.0 with localhost
Console config
Add console experience for topaz
Bump self-hosted-console
* fix migrate test * add service cleanup
This reverts commit 5b5dfd9.
* migrate all builtins to be v3 based, adds handling for v2 and v3 request payloads, v2 request return v2 results, help * is always v3 based * migrate and reorganize tests, remove gomega/ginko dependency * add service cleanup, the cleanup function returned by wire does not cleanup, leaving the database open
updated citadel data in v3 branch
florindragos
force-pushed
the
fix_gdrive
branch
from
October 27, 2023 14:29
ab1ecb7
to
11d918f
Compare
florindragos
force-pushed
the
fix_gdrive
branch
from
October 27, 2023 14:30
11d918f
to
ff0c124
Compare
Please note:
|
gertd
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The object and relation formats used are v2 formats, gDrive requires subject_relation to be able to be expressed and set in the relations; hence the data format should be updated to V3 object and relation shapes.
@florindragos is this PR still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.