Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix builtin not found err handling #209

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix builtin not found err handling #209

merged 1 commit into from
Dec 12, 2023

Conversation

gertd
Copy link
Member

@gertd gertd commented Dec 12, 2023

Fix builtins that return singleton results when gRPC is a NOT_FOUND error, return an ast.NullTerm instead of an error.
The error is returned in the trace fail notes

Copy link

Pull Request Test Coverage Report for Build 7177056795

  • 11 of 18 (61.11%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 40.195%

Changes Missing Coverage Covered Lines Changed/Added Lines %
builtins/edge/ds/identity.go 2 3 66.67%
builtins/edge/ds/object.go 3 5 60.0%
builtins/edge/ds/relation.go 3 5 60.0%
builtins/edge/ds/user.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
builtins/edge/ds/identity.go 1 84.21%
Totals Coverage Status
Change from base Build 7166513616: 0.7%
Covered Lines: 1441
Relevant Lines: 3585

💛 - Coveralls

Copy link
Contributor

@carabasdaniel carabasdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gertd gertd merged commit e188fd6 into main Dec 12, 2023
5 checks passed
@gertd gertd deleted the fix/builtin-not-found-err branch December 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants