Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client/connection validation #500

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Update client/connection validation #500

merged 7 commits into from
Nov 28, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Nov 28, 2024

  • remove grpcurl dependency
  • consolidate cc.IsServing(), clients.directory.Validate() and clients.authorizer.Validate() with a single implementation in clients.Validate(). This implementation can also be used in the Aserto CLI, by implementing the interface on the tenant and other clients.
  • consolidate error messages.
  • add Timeout parameter to client struct, used to set context timeout.
  • update template tests, setting the timeout

@gertd gertd marked this pull request as ready for review November 28, 2024 00:44
@coveralls
Copy link

coveralls commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12072058137

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 12056919666: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

carabasdaniel
carabasdaniel reviewed Nov 28, 2024
View reviewed changes
pkg/cli/cc/cc.go Outdated Show resolved Hide resolved
@gertd gertd merged commit 52871cf into main Nov 28, 2024
5 checks passed
@gertd gertd deleted the client-validate branch November 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carabasdaniel carabasdaniel carabasdaniel approved these changes

@ronenh ronenh Awaiting requested review from ronenh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gertd @coveralls @carabasdaniel