improvement: add :primary_key_type option #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aifrak this is great. Thank you! There are a couple of CI issues to address that you can address or I will when I have a moment. |
|
@rgraff Thank you for your feedback. I have pushed fixes that should normally make the CI green again. |
|
@aifrak Thank you for your contribution 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
This PR adds
:primary_key_typeto give the option to choose between:uuid(default),:uuid_v7and:integerfor the primary key.The test for
:integeris a special case and I have let a comment there.:primary_key_typeis also added to.formatter.exs.