feat(headers): added flow for custom headers #4

mikecabana · 2021-05-18T17:22:56Z

Email setting or query variables will overwrite the custom headers like here

if (isset($from) && !empty($from)) {
    $headers[] = 'From: ' . $from;
} else if (isset($defaultFrom) && !empty($defaultFrom)) {
     $headers[] = 'From: ' . $defaultFrom;
}

Fixes #3

ashhitch · 2021-06-10T13:07:30Z

wp-graphql-send-mail.php

@@ -152,6 +168,10 @@ function wpgraphql_send_mail_options_page()
        'type' => 'String',
        'description' => __('Body of email', 'wp-graphql-send-mail'),
      ],
+      'headers' => [
+        'type' => 'String',


Should this be
['type' => ['list_of' => 'String']]
To allow for an array of headers to be sent?

It definitely can, I just wanted to keep it simple and use the same logic as the origins since I'm not too savvy in PHP

feat(headers): added flow for custom headers

1e8e8ff

ashhitch reviewed Jun 10, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(headers): added flow for custom headers #4

feat(headers): added flow for custom headers #4

mikecabana commented May 18, 2021 •

edited

Loading

ashhitch Jun 10, 2021

mikecabana Jun 14, 2021

feat(headers): added flow for custom headers #4

Are you sure you want to change the base?

feat(headers): added flow for custom headers #4

Conversation

mikecabana commented May 18, 2021 • edited Loading

ashhitch Jun 10, 2021

Choose a reason for hiding this comment

mikecabana Jun 14, 2021

Choose a reason for hiding this comment

mikecabana commented May 18, 2021 •

edited

Loading