Xpdf rc path Compatibility with Code Freezing Tools #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
…the pyxpdf_rc file based on the current location of the package. This make the package compatible with code freezing tools such as PyInstaller. * This commit adds a PyPI dep 'appdirs' to the pyxpdf_data package.
|
Thanks for the PR @mush42! Also apologies for the late reply, It was a busy week for me. |
|
Any news about the status of this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ashutoshvarma
Changes
This PR makes generating xpdf_rc file path dynamic. The path is obtained using one of two methods:
Rationale
The changes proposed in this PR are required to make the package compatible with code freezing tools such as PyInstaller as these tools disregard the site-packages directory, and package the stdlib as a zip file.
Best Regards,