-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregator support #65
Merged
Merged
+422
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
============================================
- Coverage 75.7% 74.34% -1.36%
- Complexity 121 127 +6
============================================
Files 34 36 +2
Lines 675 729 +54
Branches 79 82 +3
============================================
+ Hits 511 542 +31
- Misses 99 121 +22
- Partials 65 66 +1 |
Merged
Simple test cases to cover to non-scatter block
Adding more test cases for AggregationRouter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support doing Aggregation using Algebird's
Aggregator
abstraction.Also made some changes to support maven snapshot publishing from TravisCI. Will send in Docs update in a while. Please go through the changes.
Some problems I've in the current implementation which should be fixed before merging
Futures.allAsList(...).get
any failure is not propagated back to us because that's caught by the ExecutorService internally in guava library. Need to find out how to handle and propagate these type of failures.