Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregator support #65

Merged
merged 19 commits into from
Jun 2, 2017
Merged

Aggregator support #65

merged 19 commits into from
Jun 2, 2017

Conversation

ashwanthkumar
Copy link
Owner

@ashwanthkumar ashwanthkumar commented May 26, 2017

Support doing Aggregation using Algebird's Aggregator abstraction.

Also made some changes to support maven snapshot publishing from TravisCI. Will send in Docs update in a while. Please go through the changes.

Some problems I've in the current implementation which should be fixed before merging

  • While doing scatter we send requests to all the nodes in the cluster (incl. the node that's doing the scatter).
  • Since we use Futures.allAsList(...).get any failure is not propagated back to us because that's caught by the ExecutorService internally in guava library. Need to find out how to handle and propagate these type of failures.
  • Current implementation is for Unary methods only. Need to add support for streaming aggregation as well.

Sorry, something went wrong.

@codecov-io
Copy link

codecov-io commented May 26, 2017

Codecov Report

Merging #65 into master will decrease coverage by 1.35%.
The diff coverage is 57.4%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
- Coverage      75.7%   74.34%   -1.36%     
- Complexity      121      127       +6     
============================================
  Files            34       36       +2     
  Lines           675      729      +54     
  Branches         79       82       +3     
============================================
+ Hits            511      542      +31     
- Misses           99      121      +22     
- Partials         65       66       +1

@ashwanthkumar ashwanthkumar added this to the 0.2 milestone Jun 2, 2017
@ashwanthkumar ashwanthkumar self-assigned this Jun 2, 2017
@ashwanthkumar
Copy link
Owner Author

Merging these changes. Tracking the 2 items as part of #69 and #70.

@ashwanthkumar ashwanthkumar merged commit 386efeb into master Jun 2, 2017
@ashwanthkumar ashwanthkumar deleted the aggregator-support branch June 2, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants