Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove USING_STATIC_XERCES as this is not necessary anymore since XercesC 3.2.0 #317

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove USING_STATIC_XERCES as this is not necessary anymore since XercesC 3.2.0 #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ if ( E57_BUILDING_SELF )
endif()

find_package( Threads REQUIRED )
find_package( XercesC REQUIRED )
find_package( XercesC 3.2 REQUIRED )

option( E57_BUILD_SHARED
"Compile E57Format as a shared library"
Expand Down Expand Up @@ -194,17 +194,6 @@ target_compile_definitions( E57Format
# sanitizers
include( Sanitizers )

# xerces
if ( WIN32 )
option( USING_STATIC_XERCES "Turn on if you are linking with Xerces as a static lib" OFF )
if ( USING_STATIC_XERCES )
target_compile_definitions( E57Format
PUBLIC
XERCES_STATIC_LIBRARY
)
endif()
endif()

# Target Libraries
target_link_libraries( E57Format PRIVATE XercesC::XercesC )

Expand Down
Loading