✅ make linters happy

.github/workflows/check.yml

@@ -100,7 +100,7 @@ jobs:
       - name: Install requirements
         run: pip install -r pip-requirements.txt
       - name: Install Pylint + stuff required for checking the tests and setup.py
-        run: pip install -c pip-constraints.txt html5lib pylint pylint-pytest pytest time-machine trove-classifiers
+        run: pip install -c pip-constraints.txt html5lib pylint pylint-pytest pytest setuptools time-machine trove-classifiers
       - name: Run Pylint
         run: pylint -r y -d fixme .
         env:

an_website/__main__.py

@@ -59,7 +59,7 @@
 if sys.flags.dev_mode:
     tracemalloc.start()
     with contextlib.suppress(ValueError):
-        sys.activate_stack_trampoline("perf")  # pylint: disable=no-member
+        sys.activate_stack_trampoline("perf")
 
 if __name__ == "__main__":
     sys.exit(main())

an_website/backdoor/backdoor.py

@@ -157,7 +157,7 @@ async def load_session(self) -> dict[str, Any]:
                             value.decode("BRAILLE"),
                         )
                         if self.apm_client:
-                            self.apm_client.capture_exception()
+                            self.apm_client.capture_exception()  # type: ignore[no-untyped-call]
             else:
                 session = {
                     "__builtins__": __builtins__,

an_website/main.py

@@ -53,9 +53,7 @@
 from ecs_logging import StdlibFormatter
 from elastic_enterprise_search import AppSearch  # type: ignore[import-untyped]
 from elastic_transport import ObjectApiResponse
-from elasticapm.contrib.tornado import (  # type: ignore[import-untyped]
-    ElasticAPM,
-)
+from elasticapm.contrib.tornado import ElasticAPM
 from elasticsearch import AsyncElasticsearch, NotFoundError
 from redis.asyncio import (
     BlockingConnectionPool,
@@ -1236,7 +1234,6 @@ def main(  # noqa: C901  # pragma: no cover
         asyncio.set_event_loop(loop)
 
     if sys.version_info >= (3, 13) and not loop.get_task_factory():
-        # pylint: disable=no-member
         loop.set_task_factory(asyncio.eager_task_factory)
 
     if perf8 and "PERF8" in os.environ:

an_website/quotes/utils.py

@@ -30,7 +30,7 @@
 from typing import Any, Final, Literal, cast
 from urllib.parse import urlencode
 
-import elasticapm  # type: ignore[import-untyped]
+import elasticapm
 import orjson as json
 from redis.asyncio import Redis
 from tornado.httpclient import AsyncHTTPClient
@@ -500,7 +500,7 @@ async def update_cache_periodically(app: Application) -> None:
         await asyncio.wait_for(EVENT_REDIS.wait(), 5)
     redis: Redis[str] = cast("Redis[str]", app.settings.get("REDIS"))
     prefix: str = app.settings.get("REDIS_PREFIX", NAME).removesuffix("-dev")
-    apm: None | elasticapm.Client  # type: ignore[no-any-unimported]
+    apm: None | elasticapm.Client
     if EVENT_REDIS.is_set():  # pylint: disable=too-many-nested-blocks
         await parse_list_of_quote_data(
             await redis.get(f"{prefix}:cached-quote-data:wrongquotes"),  # type: ignore[arg-type]  # noqa: B950
@@ -536,7 +536,7 @@ async def update_cache_periodically(app: Application) -> None:
                                 "CLIENT"
                             )
                             if apm:
-                                apm.capture_exception()
+                                apm.capture_exception()  # type: ignore[no-untyped-call]
                         else:
                             LOGGER.info("Updated quotes cache successfully")
                     LOGGER.info(

an_website/search/search.py

@@ -108,7 +108,7 @@ async def search(self) -> list[dict[str, float | str]]:
             except Exception:  # pylint: disable=broad-except
                 LOGGER.exception("App Search request failed")
                 if self.apm_client:
-                    self.apm_client.capture_exception()
+                    self.apm_client.capture_exception()  # type: ignore[no-untyped-call]
         if result is not None:
             return result
         return self.search_old(query)

an_website/utils/base_request_handler.py

@@ -38,7 +38,7 @@
 from urllib.parse import SplitResult, urlsplit, urlunsplit
 from zoneinfo import ZoneInfo
 
-import elasticapm  # type: ignore[import-untyped]
+import elasticapm
 import html2text
 import orjson as json
 import regex
@@ -155,9 +155,9 @@ def _finish(
         return super().finish()
 
     @property
-    def apm_client(self) -> None | elasticapm.Client:  # type: ignore[no-any-unimported]
+    def apm_client(self) -> None | elasticapm.Client:
         """Get the APM client from the settings."""
-        return self.settings.get("ELASTIC_APM", {}).get("CLIENT")
+        return self.settings.get("ELASTIC_APM", {}).get("CLIENT")  # type: ignore[no-any-return]
 
     @property
     def apm_enabled(self) -> bool:
@@ -563,7 +563,7 @@ async def get_time(self) -> datetime:
         except (ApiError, TransportError):
             LOGGER.exception("Elasticsearch request failed")
             if self.apm_client:
-                self.apm_client.capture_exception()
+                self.apm_client.capture_exception()  # type: ignore[no-untyped-call]
         else:
             if geoip and "timezone" in geoip:
                 tz = ZoneInfo(geoip["timezone"])

an_website/utils/static_file_from_traversable.py

@@ -17,7 +17,7 @@
 
 import sys
 from collections.abc import Awaitable, Iterable
-from importlib.abc import Traversable
+from importlib.abc import Traversable  # pylint: disable=no-name-in-module
 from pathlib import Path
 
 from tornado import httputil, iostream

an_website/utils/static_file_handling.py

@@ -20,7 +20,7 @@
 import sys
 from collections.abc import Awaitable, Mapping
 from functools import cache
-from importlib.abc import Traversable
+from importlib.abc import Traversable  # pylint: disable=no-name-in-module
 from pathlib import Path
 from typing import Any, Final, cast
 

an_website/utils/utils.py

@@ -46,7 +46,7 @@
 )
 from urllib.parse import SplitResult, parse_qsl, urlencode, urlsplit, urlunsplit
 
-import elasticapm  # type: ignore[import-untyped]
+import elasticapm
 import regex
 from blake3 import blake3
 from elastic_transport import ApiError, TransportError
@@ -251,7 +251,7 @@ def anonymize_ip(
 ansi_replace.__doc__ = "Remove ANSI escape sequences from a string."
 
 
-def apm_anonymization_processor(  # type: ignore[no-any-unimported]
+def apm_anonymization_processor(
     client: elasticapm.Client,  # pylint: disable=unused-argument
     event: dict[str, Any],
 ) -> dict[str, Any]:

scripts/commit.py

@@ -18,7 +18,7 @@
 from __future__ import annotations
 
 import os
-import subprocess
+import subprocess  # nosec: B404
 import sys
 from datetime import datetime, timezone
 from os.path import dirname, join, normpath
@@ -44,7 +44,7 @@ def main(*args: str) -> int | str:
         "GIT_COMMITTER_DATE": date_str,
     }
     env.update(os.environ)
-    result = subprocess.run(
+    result = subprocess.run(  # nosec: B603, B607
         ["git", "commit", "-m", message], env=env, check=False
     )
 

tests/__init__.py

@@ -40,7 +40,7 @@
 import socket
 from collections.abc import Awaitable, Callable, MutableMapping, Set
 from datetime import datetime, timezone
-from os import environ
+from os import environ  # pylint: disable=ungrouped-imports
 from pathlib import Path
 from typing import Any, cast
 from urllib.parse import parse_qsl, urlsplit

tests/test_token.py

@@ -43,7 +43,7 @@ def test_token_v0() -> None:
         b"\x00\x00\x00\x00\x00*",  # 42
     )
     assert (
-        token == "ABQAAAAAACoAAAAAZAAAAAAAVuGjEJjux2P8zah"
+        token == "ABQAAAAAACoAAAAAZAAAAAAAVuGjEJjux2P8zah"  # nosec: B105
         "9SjQGkxCWn9Iaszr/qJJHJSMWoRPoVjQKa6/jKFWPdBehSL0K"
     )