feat: remove golangci-lint #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for 1.0, we want all linters to work correctly. In the discussion for #129 we decided that is a fatal bug, and no one is able to fix it in the short term. We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it. Closes #129
gregmagolan
approved these changes
Apr 11, 2024
|
bummer! |
This was referenced Apr 11, 2024
mrmeku
pushed a commit
to mrmeku/rules_lint
that referenced
this pull request
Apr 15, 2024
In preparation for 1.0, we want all linters to work correctly. In the discussion for aspect-build#129 we decided that is a fatal bug, and no one is able to fix it in the short term. We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it. Closes aspect-build#129
mrmeku
pushed a commit
to mrmeku/rules_lint
that referenced
this pull request
Apr 15, 2024
In preparation for 1.0, we want all linters to work correctly. In the discussion for aspect-build#129 we decided that is a fatal bug, and no one is able to fix it in the short term. We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it. Closes aspect-build#129
alexeagle
added a commit
that referenced
this pull request
Apr 22, 2024
* feat: remove golangci-lint (#207) In preparation for 1.0, we want all linters to work correctly. In the discussion for #129 we decided that is a fatal bug, and no one is able to fix it in the short term. We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it. Closes #129 * Move changes from linting.md to formatting.md * Address review comments --------- Co-authored-by: Alex Eagle <[email protected]>
alexeagle
added a commit
that referenced
this pull request
May 31, 2024
In preparation for 1.0, we want all linters to work correctly. In the discussion for #129 we decided that is a fatal bug, and no one is able to fix it in the short term. We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it. Closes #129
alexeagle
added a commit
that referenced
this pull request
May 31, 2024
* feat: remove golangci-lint (#207) In preparation for 1.0, we want all linters to work correctly. In the discussion for #129 we decided that is a fatal bug, and no one is able to fix it in the short term. We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it. Closes #129 * Move changes from linting.md to formatting.md * Address review comments --------- Co-authored-by: Alex Eagle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for 1.0, we want all linters to work correctly. In the discussion for #129 we decided that is a fatal bug, and no one is able to fix it in the short term.
We're happy to add Go linting back to rules_lint when someone has a correct implementation that handles transitive srcs. The code will still be here in the git history when it's time to revive it.
Closes #129
Type of change
Well, the opposite of a feature, whatever you call that...
For changes visible to end-users
BREAKING: there is no longer a
lint_golangci_aspectsymbol. Support for Go linting will hopefully be restored in a later release.Test plan