Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't totally ignore KeyboardInterrupt #94

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Don't totally ignore KeyboardInterrupt #94

merged 1 commit into from
Apr 3, 2021

Conversation

aspiers
Copy link
Owner

@aspiers aspiers commented May 20, 2019

UNTESTED: can't test until #87 is resolved (hopefully by #93).

This should revert commit 2a05400. I have no idea why I did that, but if the reason emerges after the revert, we should address it in some other more sensible way.

Fixes #83 and #89.

Commit 2a05400 ignored KeyboardInterrupt.  I'm *guessing* I did that
to avoid an ugly stacktrace, but even if so, the user's desire to
interrupt execution should not be ignored in this way.

Fixes #83 and #89.
@aspiers aspiers changed the title [UNTESTED] Revert "ignore KeyboardInterrupt" Don't totally ignore KeyboardInterrupt Apr 3, 2021
@aspiers aspiers merged commit b7d047d into master Apr 3, 2021
@aspiers aspiers deleted the ctrl-c branch April 3, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git deps cannot be stopped with CTRL-C
1 participant