Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to target .NET 8 #808

Merged
merged 26 commits into from
Nov 14, 2023
Merged

Update to target .NET 8 #808

merged 26 commits into from
Nov 14, 2023

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Oct 2, 2023

Update the providers to target net8.0 with the .NET 8 SDK. Changes, in no particular order, include:

  • Add a README file to the NuGet packages as recommended by the .NET 8 SDK.
  • Remove obsolete TODO.
  • Remove usage of ISystemClock and use TimeProvider instead.
  • Suppress CA1861 in tests.
  • Apply some style and syntax suggestions from Visual Studio.
  • Use AuthenticationFailureException where relevant.
  • Use ArgumentException.ThrowIfNullOrWhiteSpace() where relevant.
  • Specify value with ArgumentOutOfRangeException where relevant.
  • Suppress CA1863 warnings to use CompositeFormat.
  • Use JsonDocument.ParseAsync() where relevant.
  • Remove obsolete members for the EVEOnline provider.
  • Use primary constructors where relevant.
  • Use collection literals where relevant.
  • Add helper method to reduce duplicative tests.
  • Remove redundant using statements.
  • Fix some typos.
  • Hide shared files from the Visual Studio project explorer.
  • Update to the latest release of Arcade for .NET 8.
  • Add support for AoT scenarios.

- Update to preview 3 of ASP.NET Core 8.
- Add a README file to the NuGet packages as recommended by the .NET 8 SDK.
Remove obsolete TODO.
Update to preview 4 of ASP.NET Core 8.
- Update to preview 5 of ASP.NET Core 8.
- Remove usage of `ISystemClock` and use `TimeProvider` instead.
- Suppress `CA1861` in tests.
- Apply some style suggestions from Visual Studio.
* Update exception types

- Use `AuthenticationFailureException` where relevant.
- Use `ArgumentException.ThrowIfNullOrWhiteSpace()` where relevant.
- Specify value with `ArgumentOutOfRangeException` where relevant.

* Revert accidental change

Revert back to `SecurityTokenValidationException` in one place.
Update to preview 6 of ASP.NET Core 8.
- Update to preview 7 of ASP.NET Core 8.
- Suppress `CA1863` warnings to use `CompositeFormat`.
- Use `JsonDocument.ParseAsync()` where relevant.
- Remove `ISystemClock`.
- Suppress `CA1863`.
Remove obsolete members for the EVE Online provider.
- Use primary constructors where relevant.
- Use collection literals where relevant.
- Add helper method to reduce duplicative tests.
- Apply some IDE suggestions.
- Remove redundant using statements.
- Fix some typos.
- Hide shared files from the Visual Studio project explorer.
@martincostello martincostello added this to the 8.0.0 milestone Oct 2, 2023
Use collection literals for string arrays.
Update to the latest release of arcade for .NET 8.
- Update to RC 2 of ASP.NET Core 8.
- Update NuGet packages to their latest versions.
- Fix obsolete warnings.
- Fix StyleCop warning.
- Fix tests after update to Wilson 7.0.0.
Bump Microsoft.IdentityModel.Protocols to 7.0.3 as there's been some bugs in v7 that .NET 8 is picking up e.g. dotnet/aspnetcore#51430.
Bump JetBrains.Annotations to the latest version.
Add support for native AoT for the libraries.
- Trim off all the fractions of a second before comparing.
- Remove redundant casts.
Fix query string parameters being duplicated if `AuthorizationEndpoint` contains any user-added query string parameters.
Use unified BattleNet server

Resolves #812.
Update to stable .NET 8 SDK and NuGet packages.
@martincostello martincostello marked this pull request as ready for review November 14, 2023 15:19
@martincostello martincostello merged commit 5164ca0 into dev Nov 14, 2023
15 checks passed
@martincostello martincostello deleted the dev-v8 branch November 14, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant