Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feishu provider claims. #821

Closed

Conversation

vicenteyu
Copy link
Contributor

Add new claims:

  • Sub;
  • Name;
  • Picture;
  • OpenId;
  • EnName;
  • TenantKey;
  • AvatarUrl;
  • AvatarThumb;
  • AvatarMiddle;
  • AvatarBig;
  • Email;
  • UserId;
  • EmployeeNo;
  • Mobile;

Signed-off-by: Vicente.Yu <^@^>
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all these claims need to be added? We typically don't exhaustively add everything as users can trivially opt-in to map additional claims through configuration.

Signed-off-by: Vicente.Yu <^@^>
@vicenteyu
Copy link
Contributor Author

Adding more claims will make it easier to use.

@martincostello
Copy link
Member

I get that it makes it "easier", but it also means mapping more things that an integration might actually use.

I'm not convinced there's a need to add all these additional mappings in the common/default case of just logging in a user and knowing their identity.

@vicenteyu
Copy link
Contributor Author

I get that it makes it "easier", but it also means mapping more things that an integration might actually use.

I'm not convinced there's a need to add all these additional mappings in the common/default case of just logging in a user and knowing their identity.

Maybe making it an expansion pack is a more appropriate way, thank you.

@vicenteyu vicenteyu closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants