Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAuth endpoints, fix form un-escaping #380

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Sep 3, 2020

#327 - our regular update of oauth endpoints. No observable behavior changes.

When manually testing I realized that #368 broke form decoding in two paces when replacing + with .
The first was fixed by #379

I've included the fix for the second one in this PR because WsFed doesn't work without it. In short, plus decoding needs to be turned on for forms parsing, we only needed to turn it off for cookies.

@Tratcher Tratcher added this to the 4.1.1 milestone Sep 3, 2020
@Tratcher Tratcher requested a review from HaoK September 3, 2020 21:19
@Tratcher Tratcher self-assigned this Sep 3, 2020
@Tratcher Tratcher merged commit 7aa465d into dev Sep 8, 2020
@Tratcher Tratcher deleted the tratcher/oauth branch September 8, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants