Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MSBuild 17.7 issue. #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

AraHaan
Copy link

@AraHaan AraHaan commented Aug 16, 2023

This should fix an issue with newer versions of msbuid for both .NET SDK style and non-SDK style projects all in one.

Fixes #154.

This should fix an issue with newer versions of msbuid for both .NET SDK style and non-SDK style projects all in one.
@AraHaan
Copy link
Author

AraHaan commented Aug 22, 2023

cc: @StephenMolloy

@danpetitt
Copy link

Any chance getting this merged and a new version released?

@robmaas
Copy link

robmaas commented Aug 31, 2023

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

@fiseni
Copy link

fiseni commented Sep 8, 2023

Looking forward this to being merged.

@AraHaan
Copy link
Author

AraHaan commented Sep 9, 2023

If you guys are also interested I also opened a pull request for shipping this package with roslyn 4.7 which is more updated and modern version of roslyn with updated c# language versions support as well.

@rainersigwald
Copy link

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

@AraHaan
Copy link
Author

AraHaan commented Oct 6, 2023

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

It is breaking it because it helps point out that msbuild was unable to copy the files at all for the reason that the message pointed out.

The lack of the compiler files themselves is what is breaking which ironically fixes itself when the changes in this patch is applied.

@robmaas
Copy link

robmaas commented Oct 6, 2023

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

When this issue started it also showed as building warnings in our build in Hosted Azure DevOps agents.
Since we have a no-tolerance process it broke our deployment process.
At the moment those warnings no longer show up in the pipelines, not sure what changed but they definitely did before.

@AraHaan
Copy link
Author

AraHaan commented Oct 6, 2023

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

When this issue started it also showed as building warnings in our build in Hosted Azure DevOps agents. Since we have a no-tolerance process it broke our deployment process. At the moment those warnings no longer show up in the pipelines, not sure what changed but they definitely did before.

Also since then has the roslyn binaries vanished from deployments as well in the agents?

…m/build/Microsoft.CodeDom.Providers.DotNetCompilerPlatform.targets

Co-authored-by: Jan Krivanek <[email protected]>
…m/build/Microsoft.CodeDom.Providers.DotNetCompilerPlatform.targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential incompatibility with MSBuild 17.7
6 participants