Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v141 toolchain support (VS2017) and examples of building a single dll #59

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

boczar
Copy link

@boczar boczar commented Apr 29, 2021

So, this change probably contains more than needed, but I wanted to demonstrate the spirit of my work.

The most obvious one is suppressing additional warnings, ideally I'd figure out why they are happing in the first place.
Secondly, I've added two batch files and two example triplet files to build a single .dll (vs. the 7 that get generated by default).

Thirdly, I made some refactoring so that you can compile/link against the library without the cpprestsdk dependency. Right now if the library is built with USE_CPPRESTSDK but the application doesn't define that macro, you'll get nasty stack memory overwrites when using the signalr_client_config structure. I moved out the cpprestsdk specific configuration options to its own class which is optional for the application. If you do define the macro, you have to distribute/include the cpprestsdk headers and a fair amount of other dependencies (like boost 😫).

Alexander Boczar added 2 commits April 28, 2021 13:39
build scripts
remove cpprestsdk header dependency
@ghost
Copy link

ghost commented Apr 29, 2021

CLA assistant check
All CLA requirements met.

@boczar
Copy link
Author

boczar commented Apr 29, 2021

@BrennanConroy - The multiple connect test failed on linux, I'm pretty sure I didn't touch that part. Can the tests be rerun?

@RayKoopa
Copy link

This is great! Would love to see a static / less dependency version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants