add target option to links #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
alishaevn
reviewed
Nov 15, 2023
src/components/Link/Link.jsx
Outdated
| } | ||
|
|
||
| Link.defaultProps = { | ||
| addClass: '', | ||
| icon: '', | ||
| style: {}, | ||
| target: '' |
There was a problem hiding this comment.
the default value for this attribute is target='_self'. (ref: docs) what behavior does an empty string perform?
There was a problem hiding this comment.
it does the exact same thing as target='_self', but i will change it to self if for best practices purposes
alishaevn
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Adds a target prop so users can optionally pass
target: _blankin order to open footer links in a new tabRelated
Acceptance
target: _blankpropVideo
https://share.zight.com/04ud8wnJ