Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change mapbox config to filter location in the entire world based on country, place and address #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change mapbox config to filter location in the entire world based on country, place and address #184

wants to merge 1 commit into from

Conversation

rmkni
Copy link
Collaborator

@rmkni rmkni commented Jun 27, 2024

@rmkni rmkni requested review from srosset81 and mguihal June 27, 2024 12:58
@rmkni rmkni linked an issue Jun 27, 2024 that may be closed by this pull request
Pouvoir renseigner les adresses d'acteurs en dehors de France Métropolitaine #114
Open
srosset81
srosset81 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@srosset81 srosset81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we could add an env variable with this setting ?

@mguihal
Copy link
Collaborator

mguihal commented Jul 2, 2024

Maybe in the future we could add an env variable with this setting ?

Yes, and I would add it directly in this PR if possible.
We can for example create a new "mapboxCountries" setting in the config.ts file, with the array of searchable countries, empty by default if all countries accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosset81 srosset81 srosset81 approved these changes

@mguihal mguihal Awaiting requested review from mguihal

Assignees

@rmkni rmkni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pouvoir renseigner les adresses d'acteurs en dehors de France Métropolitaine
3 participants
@rmkni @mguihal @srosset81