fix accept for file #1012
Open
fix accept for file #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srosset81
requested changes
Jul 11, 2022
| let type = triples.find(q => ['http://www.w3.org/1999/02/22-rdf-syntax-ns#type'].includes(q.predicate.value)) | ||
| .object.value; | ||
|
|
||
| if (['http://semapps.org/ns/core#File', 'semapps:File'].includes(type) && !forceSemantic) { |
There was a problem hiding this comment.
Comme bodyToTriples retourne des quads, ce ne sera jamais semapps:File mais toujours des URIs complets. Même chose pour mimeType et localPath.
There was a problem hiding this comment.
Par ailleurs, ce serait bien de mettre la condition if (!forceSemantic) avant l'appel à bodyToTriples, ça évite de faire ces calculs coûteux (forceSemantic est souvent true, par exemple lorsque ldp.resource.get est appelé par ldp.container.get)
There was a problem hiding this comment.
j'ai eu le cas d'un semapps:Filec'est pour ca que j'ai pris des précautions. Je crois que c'est dans le cas d'un json-ld avec prefix/context
added 2 commits
July 11, 2022 12:35
srosset81
approved these changes
Jul 11, 2022
| @@ -0,0 +1,4 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
| # yarn lockfile v1 | |||
There was a problem hiding this comment.
Si tu peux effacer ce fichier inutile STP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1011