refactoring: simplified Log method

error_logger_impl.go

@@ -25,20 +25,18 @@ type errorLoggerImpl struct {
 }
 
 const (
-	failOutput                  = "\n--- FAIL: %s\n\t%s:%d\n\t\t%s\n"
-	failOutputWithoutFailLine   = "\t%s:%d\n\t\t%s\n"
-	failOutputWithoutLineNumber = "\t\t%s\n"
+	formatHeaderFull  = "\n--- FAIL: %s\n\t%s:%d\n"
+	formatHeaderShort = "\t%s:%d\n"
+	formatMessage     = "\t\t%s\n"
 )
 
 func (logger *errorLoggerImpl) Log(location *location, message string) {
-	args := []interface{}{location.Test, location.FileName, location.Line, message}
 	if logger.prevTestName != location.Test {
-		fmt.Fprintf(logger.writer, failOutput, args...)
+		fmt.Fprintf(logger.writer, formatHeaderFull, location.Test, location.FileName, location.Line)
 	} else if logger.prevTestLine != location.Line {
-		fmt.Fprintf(logger.writer, failOutputWithoutFailLine, args[1:]...)
-	} else {
-		fmt.Fprintf(logger.writer, failOutputWithoutLineNumber, message)
+		fmt.Fprintf(logger.writer, formatHeaderShort, location.FileName, location.Line)
 	}
+	fmt.Fprintf(logger.writer, formatMessage, message)
 	logger.prevTestName = location.Test
 	logger.prevTestLine = location.Line
 }