you shall not pass wrong arguments to provideLocation

assertgo · Dec 21, 2014 · a08cd04 · a08cd04
1 parent 61358e2
commit a08cd04
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/location_provider_impl.go b/location_provider_impl.go
@@ -24,7 +24,10 @@ func testCallerInfo(skip int) (testName string, path string, line int) {
 }
 
 func callerInfo(skip int) (methodName string, path string, line int) {
-	pc, path, line, _ := runtime.Caller(skip + 1)
+	pc, path, line, ok := runtime.Caller(skip + 1)
+	if !ok {
+		panic("you shall not pass!")
+	}
 	methodName = methodNameFromPC(pc)
 	return
 }

diff --git a/location_provider_test.go b/location_provider_test.go
@@ -21,3 +21,13 @@ func TestLocationProviderCalledFromAnotherFunction(t *testing.T) {
 		&location{"TestLocationProviderCalledFromAnotherFunction", "location_provider_test.go", 6},
 	)
 }
+
+func TestLocationProviderPanicsWhenUsedIncorrectly(t *testing.T) {
+	assert := Setup(t)
+	defer func() {
+		r := recover()
+		assert.That(r).IsEqualTo("you shall not pass!")
+	}()
+	provideLocation(1)
+	t.Fail()
+}