Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] don't include Unknown in the type for a conditionally-defined import #13563

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[red-knot] don't include Unknown in the type for a conditionally-defined import #13563

wants to merge 8 commits into from
+141 −36

Commits on Oct 15, 2024

  1. use Never type instead of Unknown for unbound public types 

    Uses `Type::Never` instead of `Type::Unknown` for the case where
a publicly available variable is unbound. In the case where it is
unbound, we want a union of its actual type with `Never` instead of
`Unbound`, because the `Unbound` case will cause runtime error.
    @pilleye
    pilleye committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    77a9bff View commit details
    Browse the repository at this point in the history

  2. fix incorrect path

    @pilleye
    pilleye committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    73ae646 View commit details
    Browse the repository at this point in the history

  3. add file diagnostic on never type

    @pilleye
    pilleye committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    acbcb1e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. undo changes to may be unbound

    @pilleye
    pilleye committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5a904dd View commit details
    Browse the repository at this point in the history

  2. simplify contains_unbound

    @pilleye
    pilleye committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1e05e27 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @pilleye
    pilleye committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e77b701 View commit details
    Browse the repository at this point in the history

  4. undo unbound to never changes in local tests

    @pilleye
    pilleye committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8baf3ae View commit details
    Browse the repository at this point in the history

  5. don't fallback to unknown type with declarations

    @pilleye
    pilleye committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2cb2945 View commit details
    Browse the repository at this point in the history