Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace members: Added symbolic link support #1074

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LLouice
Copy link

@LLouice LLouice commented May 12, 2024

No description provided.

@zanieb
Copy link
Member

zanieb commented May 13, 2024

Hi! Can you say a bit more about why this change is important or link to some prior discussion?

@LLouice
Copy link
Author

LLouice commented May 15, 2024

Sorry for the late reply.

I am not sure if the fact that workspace members do not follow symbolic links is intentional. If it is, perhaps we could add a clear flag like follow-link = true to accommodate this PR. The reason I want to add this feature is to solve an issue I am facing, which is as follows:

- MyMonoRepo
  - libs
    - util_lib
  - Projects
    - projectA
      - src
        - projectA
      - pyproject.toml
      - libs
        - util_lib_lnk -> MyMonoRepo/libs/util_lib  # symbolic link as workspace member
        
      - projectB

When developing any project, such as projectA, I want to include util_lib as a workspace member and install it editable locally. However, util_lib is not located within the projectA directory, and I found that this can be achieved through symbolic links.

Is there another method that I am not aware of that can accomplish what I want?

It seems that PR #1023 is related to this PR, as both are about locating workspace members in a mono repo. Symbolic links seem to be a possible solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants