Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibile toolchain #1429

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

PushUpek
Copy link
Contributor

@PushUpek PushUpek commented Nov 6, 2024

Resolves: #1426

This pull request includes an update to the compatibility range for the supported Python versions in the is_self_compatible_toolchain function.

@zanieb
Copy link
Member

zanieb commented Nov 6, 2024

How did you test this change?

@zanieb
Copy link
Member

zanieb commented Nov 6, 2024

(Thanks for contributing to the project!)

@PushUpek
Copy link
Contributor Author

PushUpek commented Nov 6, 2024

I used this dockerfile for test this change

FROM python:3.13-slim-bullseye

ENV PYROOT=/pyroot \
  RYE_HOME=/pyroot/.rye \
  RYE_TOOLCHAIN=/usr/local/bin/python \
  RYE_INSTALL_OPTION="--yes" \
  PATH=/pyroot/.rye/shims:/pyroot/bin:/root/.cargo/bin:$PATH 

RUN mkdir $PYROOT

RUN apt update \
  && apt-get install -y apt-utils 2>&1 | grep -v "debconf: delaying package configuration, since apt-utils is not installed" \
  && apt-get install -y build-essential git \
  && apt install -y curl 

RUN curl https://sh.rustup.rs -sSf | sh -s -- -y

RUN mkdir -p $RYE_HOME/shims
RUN cargo install --git https://github.com/PushUpek/rye.git --branch fix-compatibile-toolchain rye
RUN rye self install ${RYE_INSTALL_OPTION}
RUN rye config --set-bool behavior.global-python=true

@charliermarsh charliermarsh merged commit 7b8b101 into astral-sh:main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using existing toolchain 3.13.0
3 participants