Mark sync::sync_dry_run test as requiring python-managed
#11415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark `sync::sync_dry_run` as requiring `python-managed`, as it fails
with system Python executables due to extraneous Python packages being
installed:
```
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: sync_dry_run
Source: crates/uv/tests/it/sync.rs:6574
────────────────────────────────────────────────────────────────────────────────
Expression: snapshot
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
5 5 │ Using CPython 3.12.[X] interpreter at: [PYTHON-3.12]
6 6 │ Would create virtual environment at: .venv
7 7 │ Resolved 2 packages in [TIME]
8 8 │ Would create lockfile at: uv.lock
9 │-Would download 1 package
10 │-Would install 1 package
11 │- + iniconfig==2.0.0
9 │+Would uninstall 1310 packages
10 │+ - a2wsgi==1.10.8
[…]
```
|
Looks like macOS failed due to a flaky test. |
konstin
approved these changes
Feb 11, 2025
|
Thanks! |
|
This seems wrong... cc @charliermarsh Related #11376 |
|
It looks like we say Line 6650 in 0735be2 then perform the sync dry-run against the interpreter's environment instead of an empty one? |
|
Oops, so I've found a serious bug? :-) |
|
Haha, well it's just dry-run reporting (doesn't modify the environment at all), so not serious, but definitely wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mark
sync::sync_dry_runas requiringpython-managed, as it fails with system Python executables due to extraneous Python packages being installed:Test Plan