Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsive menubar to complement current togglable sidebar. #535

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

karpov-sv
Copy link
Collaborator

Idea is to have most important pages directly accessible without additional clicking.
Screenshot 2023-12-07 at 11 24 14
Screenshot 2023-12-07 at 11 24 34

Points for discussion:

  • Burger menu moved to the right to somehow fill that emtpy spot (sidebar still opens on the left). Probably when authentication will be implemented the avatar / user menu would go there, and the burger will return to leftmost slot.
  • Do we need Fink logo in the leftmost spot? Would probably visually conflict with current 'search' entry.
  • Small shadow is added for the whole header to slightly better separate it from the page content. Probably will need some adjustment when backgrounds are changed.

@JulienPeloton
Copy link
Member

Thanks @karpov-sv ! Could we keep the burger on the leftmost spot? Currently, one has to click on it on the right, and move across the screen to the left to choose an option.

@karpov-sv
Copy link
Collaborator Author

The menu has to be visually balanced from both ends, so I'd not like to move everything to the left. What about this?
Screenshot 2023-12-07 at 11 48 06

@karpov-sv
Copy link
Collaborator Author

Another possible solution would be splitting "actions" and "info" entries like that
Screenshot 2023-12-07 at 11 56 21

@JulienPeloton
Copy link
Member

I prefer the last option with the split :-)

@karpov-sv
Copy link
Collaborator Author

I prefer the last option with the split :-)

Ok, committed!

Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me -- merging?

@karpov-sv
Copy link
Collaborator Author

The code looks good to me -- merging?

I have no objections and nothing to add here, so let's do it!

@JulienPeloton JulienPeloton merged commit d0f6244 into astrolabsoftware:master Dec 7, 2023
1 check failed
@karpov-sv karpov-sv deleted the menu branch January 22, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants