Data release photometry for lightcurve panel #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eanup of lightcurve plotting code in general.
JulienPeloton
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thanks @karpov-sv ! You clear a long-standing milestone from 2020 :D
If I understand correctly, the button is always visible, but the DR data is superimposed on DC magnitude. We should make it clear to the users (they might be confused if they are on the Difference magnitude tab)
JulienPeloton
added
lightcurve
ZTF data release
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to request and display the photometry from ZTF data releases (IRSA archive) in the DC magnitudes tab of lightcurve panel. Also, shows the levels of magnr in the same tab, to be able to quickly see how much alert points actually deviate from it. The lines are not toggleable, as Plotly does not support it yet (implemented through shapes, not traces). These line plotting, and DC mag conversion in general, happen only when the nearest object is close enough (1.5 arcsec by default), i.e. when the alert is shown. The resulting DC magnitudes are also filtered to hide the points with errors exceeding 1 mag (basically, not measured), in order to make the plot more resistant to bad quality points.
Finally, some cleanup and visual simplification (e.g. removal of errorbar caps, and making errorbars slightly transparent, to make plots with many points a mit less messy) of the lightcurve plotting.