Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary page improvements #546

Merged
merged 88 commits into from
Jan 7, 2024
Merged

Conversation

karpov-sv
Copy link
Collaborator

@karpov-sv karpov-sv commented Jan 1, 2024

a.k.a. New Year PR

Set of visual fixes, adjustments and improvements for more consistent experience on the summary page and around it.

Based on #541 and thus has unnecessarily long commit list shown. Hope it will be reduced after #541 merge.

As usual, demo version is available at http://157.136.250.93:24000

… is smaller than 400 px, to optimize the display on smaller landscape screens
…ing on the Search link from GET-constructed results page
Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- there are many super improvements! I leave here my feedback on suggested changes.

dmc.Paper without options

You systematically removed the options radius='xl', p='md', shadow='xl', withBorder=True to dmc.Paper component for lightcurves. I prefer by far to keep the options as before, as rendering without the options is not great to my opinion.

Summary page accordion (right side)

I noticed an opened item does not close anymore when I open a new one. Is it on purpose? I cannot find the option on the code that does that (and I prefer when only one item at a time is open -- i.e. the previous behaviour).

Stamp modal removed

Some people reported they were using the enlarged stamps from the modal because the ones on the right were too small. I will be against making the current cutouts bigger for space reasons, but probably we should reintroduce the modal with enlarged stamps?

apps/plotting.py Outdated Show resolved Hide resolved
apps/cards.py Show resolved Hide resolved
@karpov-sv
Copy link
Collaborator Author

Stamp modal removed

Yes, I understand the wish to have them bigger - but in its current form the popup is ugly and useless. Until we get some better idea what to add there - I suppose the zoom feature of smaller cutouts is enough for inspecting the fine details.

@karpov-sv
Copy link
Collaborator Author

Summary page accordion (right side)

Having several panels open there is essential as otherwise you cannot simultaneously see the cutouts and alert contents for selected point - and it is important when clicking through the data.

Actually, I thought you intentionally used AccordionMultiple there, and just forgot to properly enable it (the befaviour is actually defined by whether you use single value or list as initial value for the component).

@JulienPeloton
Copy link
Member

Stamp modal removed

Yes, I understand the wish to have them bigger - but in its current form the popup is ugly and useless. Until we get some better idea what to add there - I suppose the zoom feature of smaller cutouts is enough for inspecting the fine details.

I propose that until we get some better idea, we keep the previous button.

index.py Show resolved Hide resolved
Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me -- can I merge these changes?

@karpov-sv
Copy link
Collaborator Author

Hi @JulienPeloton, yes, sure! You may merge it

@JulienPeloton JulienPeloton merged commit a4a82c1 into astrolabsoftware:master Jan 7, 2024
1 check failed
@karpov-sv karpov-sv deleted the summary branch January 22, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants