-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FITS DatasourceV2 #89
base: master
Are you sure you want to change the base?
Conversation
…en the Catalyst type is not same as the scala type, String type for example is converted internally to UTF8String; Lets seee
Scala 2.11 the build will fail. This is something we should consider, these changes are compiled against Spark 3.0 which requires scala 2.12. I don't think we can compile this against Spark 2.4.3 because as far as I know the V2 APIs are different between those two versions. I'll give it a try, if they have ported the changes back to 2.4.3 it might work |
Good point - we are at this moment of transition where we need to take a decision on what to support. The future being spark v3 with the associated DSv2, we should primarily focus on this combination for this PR. We can always let a branch open to deal with spark 2.4 support. If there is a chance of backporting, it should be secondary (although important!). |
@JulienPeloton Yup checked it. As expected does not compile with Spark 2.4.3 |
Thanks - good to know for the future. I will make the review of the current code asap. |
Hi @mayurdb - I haven't forgotten this important one, I am just overwhelmed these times... |
There are still few ToDos -
1. Add unit tests2. Add examples
3. Check the working on a larger dataset
4. Test corner cases (covered in the UTs I guess)4. Currently, the user will have to give format as fitsv2. We will have to check based on some conf if we can toggle between v1 and v2, as that would be more ideal.
5. Some of the v1 code is replicated in utils for use in v2, refactor the v1 code to use the code in utils