Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dbt exposure selector #1559

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ghjklw
Copy link
Contributor

@ghjklw ghjklw commented Feb 24, 2025

Description

Implement dbt exposure selector, following exactly the same pattern as source.

Related Issue(s)

Closes #1551

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 24, 2025
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit 521a943
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67c10c5f831d060008b3bda8
😎 Deploy Preview https://deploy-preview-1559--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dosubot dosubot bot added the area:selector Related to selector, like DAG selector, DBT selector, etc label Feb 24, 2025
@tatiana tatiana added this to the Cosmos 1.10.0 milestone Feb 27, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.31%. Comparing base (0811e46) to head (521a943).

Files with missing lines Patch % Lines
cosmos/dbt/selector.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
- Coverage   97.34%   97.31%   -0.03%     
==========================================
  Files          80       80              
  Lines        4903     4923      +20     
==========================================
+ Hits         4773     4791      +18     
- Misses        130      132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature. Thank you for extending Cosmos selectors, @ghjklw !
Since it is a new feature, we'll be releasing this in Cosmos 1.10

I'm happy for us to merge this feature once the tests are passing - could you please address the codecov feedback?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:selector Related to selector, like DAG selector, DBT selector, etc lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] exposure: selectors
2 participants