Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: implement TaskGroups by models folder #1566

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

maximilianoarcieri
Copy link

@maximilianoarcieri maximilianoarcieri commented Feb 27, 2025

Description

Implement grouping by folder structure in models folder.

Related Issue(s)

Closes #1552

Breaking Change?

Yes (change DAG topology)

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 27, 2025
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit d73f728
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67c74a61de8fa5000839ddf2

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 27, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 27, 2025
aximiliano Nahuel Piedras Arcieri added 2 commits March 1, 2025 21:46
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (e31fc5b) to head (d73f728).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1566   +/-   ##
=======================================
  Coverage   97.36%   97.37%           
=======================================
  Files          80       80           
  Lines        4934     4951   +17     
=======================================
+ Hits         4804     4821   +17     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximilianoarcieri
Copy link
Author

maximilianoarcieri commented Mar 3, 2025

Hi, @tatiana!

Do you have any other suggestion or advice for the feature?

It seems fine to me. I ran it with DbtDag and DbtTaskGroup using the variable in RenderConfig to make it optional and it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create TaskGroups to match the subfolder structure in the models folder
2 participants