Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SNAD-PS1-Zubercal NB #444

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add SNAD-PS1-Zubercal NB #444

wants to merge 2 commits into from

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Oct 17, 2024

It adds a NB we discussed in #416

NB has large images, so it is ~0.6MB

NB has large images, so it is ~0.6MB
@hombit hombit requested a review from mi-dai October 17, 2024 18:01
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Before [aa1780a] After [a8479e9] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_create_large_catalog
failed failed n/a benchmarks.time_create_midsize_catalog
99.4±1ms 97.5±0.7ms 0.98 benchmarks.time_kdtree_crossmatch
30.3±0.8ms 29.3±0.6ms 0.97 benchmarks.time_polygon_search

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (c478401) to head (64ffab4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   97.87%   97.62%   -0.25%     
==========================================
  Files          44       44              
  Lines        1553     1558       +5     
==========================================
+ Hits         1520     1521       +1     
- Misses         33       37       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit changed the base branch from main to development October 17, 2024 20:06
@hombit hombit marked this pull request as draft October 18, 2024 18:25
@hombit
Copy link
Contributor Author

hombit commented Oct 18, 2024

I'm making it draft until PS1 and Zubercal are available in Hats.

@hombit hombit changed the base branch from development to main October 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants