Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to scripts dir #34

Merged
merged 1 commit into from
Jan 31, 2025
Merged

chore: migrate to scripts dir #34

merged 1 commit into from
Jan 31, 2025

Conversation

SauravMaheshkar
Copy link
Contributor

Fixes #11

@pllim pllim requested a review from astrofrog December 30, 2024 17:26
@pllim
Copy link
Member

pllim commented Dec 30, 2024

@astrofrog , do you want to review? LGTM though.

Thanks, @SauravMaheshkar !

@SauravMaheshkar
Copy link
Contributor Author

SauravMaheshkar commented Jan 28, 2025 •
edited
Loading

Gentle ping @astrofrog @pllim

@pllim
Copy link
Member

pllim commented Jan 30, 2025

Would still make me feel better if @astrofrog could have a look since he wrote this originally. But I can revisit in a few days if still no reply. Thanks for your patience!

@astrofrog astrofrog merged commit 5af2884 into astropy:main Jan 31, 2025
4 checks passed
@pllim
Copy link
Member

pllim commented Jan 31, 2025

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move update_data.sh to scripts folder
3 participants
@SauravMaheshkar @pllim @astrofrog