Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding async mode to IRSA TAP based queries #3201

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 4, 2025

Currently query_tap and query_region has the new async_mode bool kwarg.

I was testing with the query listed in astropy/pyvo#629 which times out with the sync mode, but works as expected and fast! with async. I don't really understand why this latter behaviour, but it doesn't matter much either as we leave it to the user to decide which mode to use rather than building in a heuristic in astroquery.

Closes #3143

Prior discussion about changing the API approach from the duplication of methods and favouring a keyword based future: #2598

@bsipocz bsipocz added this to the v0.4.10 milestone Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.31%. Comparing base (90a44d5) to head (29ba772).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/ipac/irsa/core.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
- Coverage   68.32%   68.31%   -0.01%     
==========================================
  Files         231      231              
  Lines       19197    19199       +2     
==========================================
  Hits        13116    13116              
- Misses       6081     6083       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz merged commit 0c90d6e into astropy:main Feb 12, 2025
10 checks passed
@bsipocz bsipocz deleted the ENH_irsa_async_tap branch February 12, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: add async TAP for irsa
1 participant