Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the normalization on the convolve fine structure method to be more of a matched filter. #74

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

cmccully
Copy link
Contributor

No description provided.

@cmccully cmccully requested a review from saimn May 19, 2022 15:14
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #74 (00bb97b) into main (783f217) will increase coverage by 1.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   93.09%   94.26%   +1.16%     
==========================================
  Files           7        7              
  Lines         782      784       +2     
  Branches       12       12              
==========================================
+ Hits          728      739      +11     
+ Misses         54       45       -9     
Impacted Files Coverage Δ
astroscrappy/astroscrappy.pyx 81.55% <100.00%> (+3.87%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cmccully ,
Looking through PRs and I see I forgot to review this one and #76, sorry!
I never used the convolve method but changes look reasonable. I will merge so we can get to the many changes from #76 :)

@saimn saimn merged commit d145f6c into main Dec 7, 2023
@saimn saimn deleted the feature/convolution-normalization branch December 7, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants