added the missing tests to specutils #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astrofrog Why did you close this PR? |
|
It was @mdboom's PR that closed this. Not quite sure why. |
|
The problem (that we just recently became aware of) is that commits that say "Closes #X" in the package template will close issues in an affiliated package when they merge that commit in. See astropy/package-template#81 for further discussion. In the future, we'll just avoid using this feature in the package template, or use the long form ( |
wkerzendorf
added a commit
that referenced
this pull request
Jun 28, 2014
added the missing tests to specutils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the tests are accessible with
python setup.py test. Specifically @shaileshahuja and @nhmc have a look.