Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using 'SonarCloud GH app' integration in favour of GH Actions #306

Open
2 tasks done
peter-rr opened this issue Jun 21, 2024 · 3 comments
Open
2 tasks done

Stop using 'SonarCloud GH app' integration in favour of GH Actions #306

peter-rr opened this issue Jun 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@peter-rr
Copy link
Member

Why do we need this improvement?

We may need to stop using 'SonarCloud GH app' integration and better start using GH Actions for that purpose.

How will this change help?

This change will avoid having issues when the SonarCloud Code Analysis workflow is not triggered, which prevents the PR's affected from being merged.

See asyncapi/cli#1470

Screenshots

No response

How could it be implemented/designed?

By having a GH workflow that does the same SonarCloud quality checks, with additional workflow_dispatch event support for manual trigger for any repo maintainer.

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

No, someone else can work on it.

@peter-rr peter-rr added the enhancement New feature or request label Jun 21, 2024
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@smoya
Copy link
Member

smoya commented Jul 4, 2024

I found a workaround that maybe helps you fix the issue. See asyncapi/parser-js#1033 (comment)

@derberg
Copy link
Member

derberg commented Jul 12, 2024

@smoya this workaround did not work in other repos - so I don't think it is the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants