Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Sonarcloud check in PR's #1033

Open
smoya opened this issue Jul 4, 2024 · 1 comment
Open

Reenable Sonarcloud check in PR's #1033

smoya opened this issue Jul 4, 2024 · 1 comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.

Comments

@smoya
Copy link
Member

smoya commented Jul 4, 2024

As you can check here, I had to manually remove the Sonarcloud check for master branch.
It seems there is some random issue. More info and possible next steps here: asyncapi/.github#306

@smoya smoya added the area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. label Jul 4, 2024
@smoya
Copy link
Member Author

smoya commented Jul 4, 2024

Reenabled.

It seems all i needed to do is to remove the required check from master branch in GH branch protection rules. Then Sonarcloud added automatically a new check into the PR's (seems like different, this one has a logo of Sonarcloud?).
Then, adding back the check in branch protection like in the following screenshot (notice that the source now says Sonarcloud, where previously said "any source").

Google Chrome_8ApoACGU@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.
Projects
None yet
Development

No branches or pull requests

1 participant